Skip to content

feat: bump serialize-javascript from 6.0.2 to 7.0.2#5589

Merged
mark-wiemer merged 3 commits intomochajs:mainfrom
JoshuaKGoldberg:serialize-javascript-7
Jan 1, 2026
Merged

feat: bump serialize-javascript from 6.0.2 to 7.0.2#5589
mark-wiemer merged 3 commits intomochajs:mainfrom
JoshuaKGoldberg:serialize-javascript-7

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 19, 2025

PR Checklist

Overview

Sending as draft for reference pending issue triage.

du -sh node_modules in a fresh repo with just mocha as a devDependency:

  • Before this change (on main): 8.1M node_modules
  • After this change: 8.0M node_modules

https://github.com/JoshuaKGoldberg/repros/tree/mocha-serialize-javascript-7

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (bc9fc84) to head (1132186).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5589   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          57       57           
  Lines        4471     4471           
  Branches      921      921           
=======================================
  Hits         4182     4182           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer
Copy link
Copy Markdown
Member

Looks like a transient test failure (#5361)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 31, 2025 22:50
@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

Nice! In that case if it's a known existing one then I'm happy marking this as ready for review. 😁

@mark-wiemer mark-wiemer merged commit 24fb1b6 into mochajs:main Jan 1, 2026
80 checks passed
@MrChocolatine
Copy link
Copy Markdown

How come these dependency updates are marked as "feature"?

@JoshuaKGoldberg JoshuaKGoldberg deleted the serialize-javascript-7 branch January 8, 2026 18:03
@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

#5484 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📦 Package: Bump serialize-javascript from 6 to 7

3 participants