Add support for forcing re-build of Images #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds force-build support (via MODAL_FORCE_BUILD and modal.toml force_build) and new optional forceBuild params across image APIs in JS/Go; deprecates JS secret arg; breaking: Go image methods now take Params structs.
MODAL_FORCE_BUILDenv andforce_buildin~/.modal.toml(modal-go/config.go,modal-js/src/config.ts).Images.FromRegistry(tag, *ImageFromRegistryParams)(addsForceBuildand optionalSecret).Images.FromAwsEcr(tag, secret, *ImageFromAwsEcrParams)andImages.FromGcpArtifactRegistry(tag, secret, *ImageFromGcpArtifactRegistryParams)(addForceBuild).Image.Build(ctx, app, *ImageBuildParams)(addsForceBuild).Sandbox.Create, examples, tests).forceBuildtoimages.fromRegistry,images.fromAwsEcr,images.fromGcpArtifactRegistry, andImage.build.secrettoImageFromRegistryParams; deprecate separatesecretarg infromRegistry(); updateApp.imageFromRegistry()/static helpers.index.ts.Written by Cursor Bugbot for commit 65e541c. This will update automatically on new commits. Configure here.