Reduce flakiness in long-running stateless HTTP tool timeout test#1300
Merged
jeffhandley merged 3 commits intomainfrom Feb 19, 2026
Merged
Reduce flakiness in long-running stateless HTTP tool timeout test#1300jeffhandley merged 3 commits intomainfrom
jeffhandley merged 3 commits intomainfrom
Conversation
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
halter73
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
This is intended to reduce test failures like the following:
Failed ModelContextProtocol.AspNetCore.Tests.MapMcpStatelessTests.LongRunningToolCall_DoesNotTimeout_WhenNoEventStreamStore [1 s]
Error Message:
System.Threading.Tasks.TaskCanceledException : The request was canceled due to the configured HttpClient.Timeout of 1 seconds elapsing.
We could consider using a timeout of larger than 1 second to reduce the flakiness, but then we'd have to make the LongRunningToolCall longer too. I think this retry logic should reduce the flakiness enough while still keeping the test shortish, but I'm open to ideas for alternative ways to test this that are faster or more reliable.
Copilot
AI
changed the title
[WIP] Update LongRunningToolCall test for reliability and performance
Reduce flakiness in long-running stateless HTTP tool timeout test
Feb 17, 2026
stephentoub
reviewed
Feb 17, 2026
stephentoub
reviewed
Feb 17, 2026
stephentoub
previously approved these changes
Feb 17, 2026
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
halter73
approved these changes
Feb 18, 2026
jeffhandley
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.