Use TimeProvider in InMemoryMcpTaskStore for deterministic testing#1303
Merged
Use TimeProvider in InMemoryMcpTaskStore for deterministic testing#1303
Conversation
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update InMemoryMcpTaskStore to use TimeProvider
Use TimeProvider in InMemoryMcpTaskStore for deterministic testing
Feb 18, 2026
stephentoub
previously approved these changes
Feb 18, 2026
halter73
reviewed
Feb 19, 2026
tests/ModelContextProtocol.Tests/Server/InMemoryMcpTaskStoreTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
halter73
approved these changes
Feb 19, 2026
jeffhandley
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add TimeProvider Support to InMemoryMcpTaskStore ✅
InMemoryMcpTaskStoreto useTimeProviderinstead ofSystem.Threading.TimerTimer?withITimer?field (conditionally compiled)TimeProviderparameter (test-only)timeProvider.CreateTimer()instead ofnew Timer()FakeTimeProviderand removeTask.DelaycallsCleanupExpiredTasks_RemovesExpiredTasksto use FakeTimeProviderDispose_StopsCleanupTimerto use FakeTimeProviderUpdateTaskStatusAsync_UpdatesLastUpdatedAtto use FakeTimeProviderCreateTaskAsync_MaxTasksPerSession_ExcludesExpiredTasksto use FakeTimeProviderListTasksAsync_ConsistentWithExpiredTasksRemovedBetweenPagesto use FakeTimeProvidercleanupInterval * 3withTimeSpan.FromTicks(cleanupInterval.Ticks * 3)Summary
Successfully updated
InMemoryMcpTaskStoreto useTimeProviderfor deterministic, fast testing. All tests that previously usedTask.Delaynow useFakeTimeProvider.Advance()to simulate time passage, making them:The changes are backward compatible with production code (using conditional compilation) and all tests pass successfully.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.