-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: Add message middleware support for session message transformation #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+275
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a middleware pattern that allows transforming JSON-RPC messages before
sending and after receiving. This provides a clean way to extend protocol
messages (e.g., adding custom capabilities to initialize requests) without
needing to subclass or override session methods.
Middleware functions receive a JSONRPCMessage and return a (possibly
transformed) JSONRPCMessage. Both sync and async middleware are supported.
Usage example:
def add_capabilities(message: JSONRPCMessage) -> JSONRPCMessage:
if isinstance(message.root, JSONRPCRequest):
# Transform the message...
pass
return message
session = ClientSession(
read_stream, write_stream,
send_middleware=[add_capabilities],
)
Changes:
- Add MessageMiddleware type alias in mcp.shared.session
- Add send_middleware and receive_middleware parameters to BaseSession
- Apply middleware in send_request, send_notification, _send_response
- Apply middleware in _receive_loop after receiving messages
- Export MessageMiddleware, JSONRPCMessage, JSONRPCNotification from mcp
- Add tests for sync and async middleware
maxisbey
requested changes
Jan 19, 2026
src/mcp/shared/session.py
Outdated
| self, message: JSONRPCMessage, middleware_list: list[MessageMiddleware] | ||
| ) -> JSONRPCMessage: | ||
| """Apply a list of middleware functions to a message.""" | ||
| import inspect |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to top
src/mcp/shared/session.py
Outdated
|
|
||
| for middleware in middleware_list: | ||
| result = middleware(message) | ||
| if inspect.isawaitable(result): |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should inspect the function first instead of doing it on every single message
Member
Author
|
Addressed the review comments:
Thanks for the feedback! |
- Move 'import inspect' to top of file - Pre-compute whether middleware is async using inspect.iscoroutinefunction() instead of checking on every message - Add test for receive_middleware to fix coverage
f932d9f to
ac97195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a middleware pattern that allows transforming JSON-RPC messages before sending and after receiving. This provides a clean way to extend protocol messages (e.g., adding custom capabilities to initialize requests) without needing to subclass or override session methods.
Motivation
When clients need to add custom fields to MCP messages (like protocol extensions or custom capabilities), they currently have to override the
initialize()method and duplicate its internal logic. This is error-prone and creates maintenance burden.A middleware approach provides a clean escape hatch that:
Example Usage
Implementation
MessageMiddlewaretype alias:Callable[[JSONRPCMessage], JSONRPCMessage | Awaitable[JSONRPCMessage]]send_middlewareandreceive_middlewareparameters toBaseSession,ClientSession, andServerSessionsend_request(),send_notification(),_send_response()for outgoing messages_receive_loop()for incoming messagesTesting
Added tests verifying: