[driver] Add AS5600 driver + generalize data-type for external encoders#1166
Merged
salkinium merged 2 commits intomodm-io:developfrom Jun 17, 2024
Merged
[driver] Add AS5600 driver + generalize data-type for external encoders#1166salkinium merged 2 commits intomodm-io:developfrom
salkinium merged 2 commits intomodm-io:developfrom
Conversation
TomSaw
force-pushed
the
driver/as5600
branch
4 times, most recently
from
56b690d to
07b44f8
Compare
TomSaw
changed the title
TomSaw
changed the title
TomSaw
changed the title
salkinium
requested changes
Jun 15, 2024
Contributor
Author
|
Done @salkinium
|
TomSaw
force-pushed
the
driver/as5600
branch
2 times, most recently
from
984dc8f to
e049ce7
Compare
Contributor
Author
|
Ready to merge I'd say... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver for a small and cheap magnetic encoder.
First, i've generalized the angle data type of existing magnetic encoder driver as5047.
👉 A consequent follow up would be to integrate
driver/encoder/angle.hppwithmath/geometry/angle.hpp. F.e. by adding conversion constructors tomath/geometry/angle.hppand drop the redundant methods ::toRadian() and ::toDegree() indriver/encoder/angle.hpp. But we might also just keep it as it is.What do you think?