Skip to content

[fiber] Make fibers a bit more useable#1172

Merged
salkinium merged 5 commits intomodm-io:developfrom
salkinium:fix/fiber_includes
Jul 10, 2024
Merged

[fiber] Make fibers a bit more useable#1172
salkinium merged 5 commits intomodm-io:developfrom
salkinium:fix/fiber_includes

Conversation

@salkinium
Copy link
Member

@salkinium salkinium commented Jun 26, 2024

The yak is not entirely shaved yet.

  • Since the modm::this_fiber::yield() function is used so often it generates a non-inlined function anyways, so it would be nice to not have to deal with recursive include issues when including only <modm/processing/fiber/functions.hpp>.
  • Would be nice to have a small polyfill library for when fibers are not implemented. For example, the timers could use a wait() method that yields the fiber until the timer has expired. This should block when fibers are not implemented.

salkinium added 2 commits July 7, 2024 21:52
The fiber functions were written explicitly to only depend on the clock.
@salkinium salkinium force-pushed the fix/fiber_includes branch 3 times, most recently from 1959fa3 to 9dd71d9 Compare July 7, 2024 22:20
@salkinium salkinium marked this pull request as ready for review July 9, 2024 00:28
@salkinium salkinium force-pushed the fix/fiber_includes branch from 9dd71d9 to 6a6802a Compare July 9, 2024 19:10
@salkinium salkinium merged commit 6a6802a into modm-io:develop Jul 10, 2024
@salkinium salkinium deleted the fix/fiber_includes branch July 10, 2024 08:44
@salkinium salkinium mentioned this pull request Aug 27, 2024
3 tasks
@salkinium salkinium added this to the 2024q2 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

std::scoped_lock not declared in my environment (Fedora 14.1.0-1.fc40)

1 participant