fix(#34): Handle ASR engine initialization panics#78
Open
SH20RAJ wants to merge 4 commits intomofa-org:mainfrom
Open
fix(#34): Handle ASR engine initialization panics#78SH20RAJ wants to merge 4 commits intomofa-org:mainfrom
SH20RAJ wants to merge 4 commits intomofa-org:mainfrom
Conversation
Fix typo 'setings' -> 'settings' in the benefits section of TabId enum documentation.
- Replace engine.as_mut().unwrap() with graceful error handling including logging - Replace mutex poisoning expect() with into_inner() recovery mechanism - Replace test unwrap() calls with expect() providing descriptive messages - Affected files: - node-hub/dora-funasr-nano-mlx/src/main.rs - apps/mofa-asr/src/screen/mod.rs - mofa-dora-bridge/src/parser.rs - node-hub/dora-gpt-sovits-mlx/src/ssml.rs Addresses potential runtime crashes from panic-based error handling.
Replace unwrap() calls on engine Option in all ASR nodes: - node-hub/dora-funasr-mlx/src/main.rs - node-hub/dora-qwen3-asr-mlx/src/main.rs These panics could freeze the entire voice chat dataflow when: - Model files are missing - Memory is exhausted - MLX framework fails Now returns logged errors instead of crashing the node process.
Author
|
Checked status: this PR is pending maintainer review/merge from upstream maintainers. I’m available to address feedback quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #34: Prevent ASR node panics when engine initialization fails. Applied to all ASR engines (FunASR, Qwen3-ASR). Uses try-catch pattern with graceful logging instead of unwrap().