fix(shared-state): replace O(n) DirtyVec eviction with VecDeque#82
Open
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Open
fix(shared-state): replace O(n) DirtyVec eviction with VecDeque#82SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Conversation
Author
|
Quick follow-up: this fix replaces DirtyVec front removal with VecDeque O(1) eviction and keeps read_if_dirty/read_all APIs unchanged. If you want, I can add micro-benchmark output in a follow-up comment once local cargo bench is run in CI-ready env. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DirtyVec::pushperformance regression when buffer is fullVec+remove(0)withVecDeque+pop_front()for O(1) evictionread_if_dirty/read_allstill returnVec<T>)Why
When
DirtyVecreaches max size, each push previously shifted all elements (remove(0)), creating O(n) behavior under high update rates.Issue
Fixes #23
Validation
I could not run
cargo testin this environment becausecargois unavailable in PATH; this change is narrowly scoped to one container type and preserves all public method signatures.