fix(shared-state): remove race in dirty-read paths#83
Open
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Open
fix(shared-state): remove race in dirty-read paths#83SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Conversation
Author
|
Quick follow-up: this patch changes dirty-read ordering to snapshot under read lock before clearing dirty flag in DirtyVec, DirtyValue, and ChatState. This targets missed-notification races under concurrent writers while preserving external method signatures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DirtyVec::read_if_dirtyDirtyValue::read_if_dirtyChatState::read_if_dirtyTechnical change
This ordering avoids clearing dirty before data is observed, which could otherwise cause missed notifications under concurrent writers.
Issue
Fixes #22
Validation
I could not run
cargo testin this environment becausecargois unavailable in PATH; the fix is localized to dirty-read methods and preserves existing public method signatures.