Travis: Arm64 tests; git depth restored; Makefile#1115
Merged
Conversation
There are four minor changes in this patch: - Arm64 testing has been enabled on Travis. As a non-x86 architecture, this will provide more robust testing of the code. - Travis MPI library switch to MPICH There were issues with using OpenMPI on Arm64, particularly with MPI_Init. Switching to MPICH appeared to resolve those issues, and MPICH has a much simpler implementation, so we've switched all jobs to it. - default git depth has been restored Our regression testing method no longer requires a complete history for comparison. - Makefile fix: dimension now reported in summary The test.summary output now includes the dimension type in the list of failed tests.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1115 +/- ##
=========================================
Coverage 46.07% 46.07%
=========================================
Files 214 214
Lines 69381 69381
=========================================
Hits 31964 31964
Misses 37417 37417 Continue to review full report at Codecov.
|
Collaborator
Author
|
Oh, I forgot when I submitted this... this will not pass until #1114 is merged. (Luckily everything else appears to have passed.) |
adcroft
approved these changes
May 21, 2020
This was referenced Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are four minor changes in this patch:
Arm64 testing has been enabled on Travis.
As a non-x86 architecture, this will provide more robust testing of
the code.
Travis MPI library switch to MPICH
There were issues with using OpenMPI on Arm64, particularly with
MPI_Init. Switching to MPICH appeared to resolve those issues, and
MPICH has a much simpler implementation, so we've switched all jobs to
it.
default git depth has been restored
Our regression testing method no longer requires a complete history
for comparison.
Makefile fix: dimension now reported in summary
The test.summary output now includes the dimension type in the list of
failed tests.