Solution for #1121#1122
Merged
marshallward merged 6 commits intomom-ocean:dev/gfdlfrom Jun 3, 2020
ESMG:dev/esmg
Merged
Conversation
Contributor
|
Looks good Kate |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1122 +/- ##
============================================
- Coverage 46.08% 46.08% -0.01%
============================================
Files 214 214
Lines 69403 69410 +7
============================================
- Hits 31986 31985 -1
- Misses 37417 37425 +8
Continue to review full report at Codecov.
|
Collaborator
Collaborator
Author
|
Hang on before merging - something I changed yesterday coughed up an out-of-bounds error. |
- was operating on segments not on core, oh no.
Collaborator
|
Updated Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10499 |
marshallward
approved these changes
Jun 3, 2020
This was referenced Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't update OBC tracer reservoirs inside the land mask or under the sea bed.