Properly set vertex_shear in set_diffusivity_init#1202
Merged
Conversation
Always call kappa_shear_at_vertex so that the Vertex_shear element of the control structure for the MOM_set_diffusivity module is always actively set. It had previously been initialized only if USE_JACKSON_PARAM is true, which led to the issues reported in MOM6 issue mom-ocean#1201. Also clarified or corrected some of the comments in MOM_kappa_shear. All answers will be bitwise identical in all cases that worked previously, and this PR corrects the problems noted in issue mom-ocean#1201, which can closed once it is accepted.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1202 +/- ##
============================================
- Coverage 46.08% 46.01% -0.07%
============================================
Files 214 224 +10
Lines 69399 70527 +1128
============================================
+ Hits 31984 32455 +471
- Misses 37415 38072 +657
Continue to review full report at Codecov.
|
Collaborator
marshallward
approved these changes
Sep 10, 2020
Collaborator
|
Overriding hanging Travis build. Otherwise everything passes. |
This was referenced Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always call kappa_shear_at_vertex so that the Vertex_shear element of the
control structure for the MOM_set_diffusivity module is always actively set. It
had previously been initialized only if USE_JACKSON_PARAM is true, which led to
the issues reported in MOM6 issue #1201. Also clarified or corrected some of
the comments in MOM_kappa_shear. All answers will be bitwise identical in all
cases that worked previously, and this PR corrects the problems noted in issue
#1201, which can closed once it is accepted.