Clean up pass_var for tracer reservoirs.#1205
Merged
Hallberg-NOAA merged 1 commit intomom-ocean:dev/gfdlfrom Sep 11, 2020
ESMG:obc_pass_var
Merged
Clean up pass_var for tracer reservoirs.#1205Hallberg-NOAA merged 1 commit intomom-ocean:dev/gfdlfrom ESMG:obc_pass_var
Hallberg-NOAA merged 1 commit intomom-ocean:dev/gfdlfrom
ESMG:obc_pass_var
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1205 +/- ##
============================================
- Coverage 46.08% 46.06% -0.02%
============================================
Files 214 224 +10
Lines 69399 70581 +1182
============================================
+ Hits 31984 32516 +532
- Misses 37415 38065 +650
Continue to review full report at Codecov.
|
Collaborator
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11164. |
Hallberg-NOAA
approved these changes
Sep 11, 2020
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes are correctly exploiting recently added capabilities to reduce the need for excessive memory allocations and message passing.
This commit pull request should be acted upon as soon as the pipeline tests have passed.
This was referenced Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new options to pass_var, saves having to allocate both directions of tracer reservoirs if only one is used.