(*) Bugfix: [uv]hml z-diags in general restrat#985
Merged
adcroft merged 1 commit intomom-ocean:dev/gfdlfrom Aug 30, 2019
Merged
(*) Bugfix: [uv]hml z-diags in general restrat#985adcroft merged 1 commit intomom-ocean:dev/gfdlfrom
adcroft merged 1 commit intomom-ocean:dev/gfdlfrom
Conversation
The z-interpolated uhml and vhml diagnostics gave inconsistent answers across layouts when using the general mixed layer restratification scheme, because the value of h had changed but its halos had not been updated. This had been previously fixed in the BML restratification but not the general stratification method. This patch updates the value of h by conditionally updating the halos if this diagnostic is required.
adcroft
approved these changes
Aug 30, 2019
Collaborator
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Look good. Testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/8794
OlgaSergienko
pushed a commit
to OlgaSergienko/MOM6
that referenced
this pull request
Dec 2, 2025
* Added frazil to ice shelf The frazil mass flux to the ice-shelf base is calculated by multiplying frazil energy [J m-2] by the inverse of the timestep times the latent heat of fusion [kg J-1 s-1]. This frazil mass flux is incorporated as a negative water flux from the ice shelf. This negative water flux then acts to add the frazil mass to the ice shelf base (MOM_ice_shelf.F90/change_thickness_using_melt) and remove it from the ocean surface as evaporation (MOM_ice_shelf.F90/add_shelf_flux). Note frazil is reset to zero at the start of each therm timestep in MOM.F90/step_MOM. Some additional changes were also made to how the ice-shelf flux factor is implemented, so that is only scales ice-shelf melt without affecting the frazil mass flux. * Fixed a commented line where fluxes%water_flux should be ISS%water_flux
claireyung
pushed a commit
to ACCESS-NRI/MOM6
that referenced
this pull request
Dec 17, 2025
* Added frazil to ice shelf The frazil mass flux to the ice-shelf base is calculated by multiplying frazil energy [J m-2] by the inverse of the timestep times the latent heat of fusion [kg J-1 s-1]. This frazil mass flux is incorporated as a negative water flux from the ice shelf. This negative water flux then acts to add the frazil mass to the ice shelf base (MOM_ice_shelf.F90/change_thickness_using_melt) and remove it from the ocean surface as evaporation (MOM_ice_shelf.F90/add_shelf_flux). Note frazil is reset to zero at the start of each therm timestep in MOM.F90/step_MOM. Some additional changes were also made to how the ice-shelf flux factor is implemented, so that is only scales ice-shelf melt without affecting the frazil mass flux. * Fixed a commented line where fluxes%water_flux should be ISS%water_flux
claireyung
added a commit
to ACCESS-NRI/MOM6
that referenced
this pull request
Dec 17, 2025
This reverts commit ef9ad05.
Hallberg-NOAA
added a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
Jan 4, 2026
Added a test to only apply frazil at the base of an ice shelf if the frazil array is allocated, thereby avoiding a segmentation fault in cases that have and ice shelf but do not have the runtime parameter FRAZIL set to true. This bug was causing the ocean_only/ISOMIP test cases to fail, and fixing it allows them to work again, providing the same answers as previously. This bug was introduced on Dec. 2, 2025 as a part of PR mom-ocean#985 to dev/gfdl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The z-interpolated uhml and vhml diagnostics gave inconsistent answers
across layouts when using the general mixed layer restratification
scheme, because the value of h had changed but its halos had not been
updated.
This had been previously fixed in the BML restratification but not the
general stratification method.
This patch updates the value of h by conditionally updating the halos if
this diagnostic is required.