GODRIVER-3540 Support Prefix/Suffix/Substring Indexes.#2267
GODRIVER-3540 Support Prefix/Suffix/Substring Indexes.#2267qingyang-hu merged 10 commits intomongodb:masterfrom
Conversation
🧪 Performance ResultsCommit SHA: ad308aeThe following benchmark tests for version 69723ef0f9613000074bce90 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
API Change Report./v2/mongo/optionscompatible changes(*EncryptOptionsBuilder).SetTextOptions: added ./v2/x/mongo/driver/mongocrypt/optionscompatible changes(*ExplicitEncryptionOptions).SetAlgorithm: added |
qingyang-hu
force-pushed
the
godriver3540
branch
from
1365b74 to
197145d
Compare
github-actions
bot
added
the
review-priority-normal
qingyang-hu
force-pushed
the
godriver3540
branch
18 times, most recently
from
07ccbf6 to
78de09d
Compare
| run-kms-tls-test: | ||
| - command: subprocess.exec | ||
| params: | ||
| binary: "bash" | ||
| env: | ||
| GO_BUILD_TAGS: cse | ||
| include_expansions_in_env: [AUTH, SSL, MONGODB_URI, TOPOLOGY, MONGO_GO_DRIVER_COMPRESSOR] | ||
| args: [*task-runner, setup-test] | ||
| - command: subprocess.exec | ||
| type: test | ||
| retry_on_failure: true | ||
| params: | ||
| binary: "bash" | ||
| include_expansions_in_env: [KMS_TLS_TESTCASE] | ||
| args: [*task-runner, evg-test-kms] |
There was a problem hiding this comment.
Merged into run-client-side-encryption-test.
| - name: "test-kms-tls-invalid-cert" | ||
| tags: ["kms-test"] | ||
| commands: | ||
| - func: bootstrap-mongo-orchestration | ||
| vars: | ||
| TOPOLOGY: "server" | ||
| AUTH: "noauth" | ||
| SSL: "nossl" | ||
| - func: start-cse-servers | ||
| - func: run-kms-tls-test | ||
| vars: | ||
| KMS_TLS_TESTCASE: "INVALID_CERT" | ||
| TOPOLOGY: "server" | ||
| AUTH: "noauth" | ||
| SSL: "nossl" | ||
| - name: "test-kms-tls-invalid-hostname" | ||
| tags: ["kms-test"] | ||
| commands: | ||
| - func: bootstrap-mongo-orchestration | ||
| vars: | ||
| TOPOLOGY: "server" | ||
| AUTH: "noauth" | ||
| SSL: "nossl" | ||
| - func: start-cse-servers | ||
| - func: run-kms-tls-test | ||
| vars: | ||
| KMS_TLS_TESTCASE: "INVALID_HOSTNAME" | ||
| TOPOLOGY: "server" | ||
| AUTH: "noauth" | ||
| SSL: "nossl" |
There was a problem hiding this comment.
Merged into run-client-side-encryption-test.
| assume-test-secrets-ec2-role: | ||
| - command: ec2.assume_role | ||
| params: | ||
| role_arn: ${aws_test_secrets_role} |
There was a problem hiding this comment.
A duplicate of L565.
There was a problem hiding this comment.
Copied from "specifications/source/client-side-encryption/etc/data/encryptedFields-prefix-suffix.json"
| SetKmsProviders(fullKmsProvidersMap). | ||
| SetKeyVaultNamespace(kvNamespace)) | ||
| mt.Run( | ||
| "1. custom key material test", |
There was a problem hiding this comment.
[blocking] Since all of these subtests are single use and because it's probably not realistic to parametarize, I think we should use the mtest.Setup API added in GODRIVER-3663:
func newCSE_T(t *testing.T) *mtest.T {
t.Helper()
verifyClientSideEncryptionVarsSet(t)
mt := mtest.New(t, mtest.NewOptions().MinServerVersion("4.2").Enterprise(true).CreateClient(false))
defaultKvClientOptions := options.Client().ApplyURI(mtest.ClusterURI())
integtest.AddTestServerAPIVersion(defaultKvClientOptions)
}
func TestClientSideEncryptionProse_CustomKeyMaterial(t *testing.T) {
t.Parallel()
mt := newCSE_T()
mt.Setup()
// logic
}
func TestClientSideEncryptionProse_DataKeyAndDoubleEncryption(t *testing.T) {
t.Parallel()
mt := newCSE_T()
mt.Setup()
// logic
}What are your thoughts?
There was a problem hiding this comment.
My only concern is that we will lose the top level t.Parallel() here in this way.
|
|
||
| // TextOptions specifies index options for a Queryable Encryption field supporting "text" queries. | ||
| // | ||
| // See corresponding setter methods for documentation. |
There was a problem hiding this comment.
[nit] Can we separate the "Beta" note with an empty line?
| // See corresponding setter methods for documentation. | |
| // See corresponding setter methods for documentation. | |
| // |
qingyang-hu
force-pushed
the
godriver3540
branch
3 times, most recently
from
acae87f to
e25a434
Compare
qingyang-hu
force-pushed
the
godriver3540
branch
from
94ec133 to
e412e8c
Compare
qingyang-hu
added
review-priority-urgent
github-actions
bot
added
the
review-priority-normal
qingyang-hu
force-pushed
the
godriver3540
branch
from
f2c59e3 to
ad308ae
Compare
GODRIVER-3540
Summary
Background & Motivation