DRIVERS-3261 Remove IndexNotFound error checks for dropIndex

[prestonvasquez]

DRIVERS-3261

SERVER-90152 changed the behavior of dropIndex() to return ok:1 instead of an IndexNotFound error when the index does not exist.

This update removes error that would result from IndexNotFound. It also removed empty spaces from the yaml files via yaml language server.

Please complete the following before merging:

• Update changelog.
• Test changes in at least one language driver.
• Test these changes against all server versions and topologies (including standalone, replica set, and sharded
  clusters).

[prestonvasquez]

@sanych-sun Note that the Go Driver skips all tests in deprecated-options.yml, since this functionality was removed in Go Driver V2.

[rozza]

I think this will need to add server versioning as well. Otherwise it error on the old MongoDBs but pass on latest.

[sanych-sun]

LGTM + verified the problem is gone on the latest variant.

[prestonvasquez]

@ShaneHarvey, @sanych-sun Suggest we remove the following templates since we need to extend the dropIndex operations to include createIndex and generate-basic-tests.py was designed to be single-operation oriented:

• deprecated-options.yml.template
• global-timeoutMS.yml.template
• override-collection-timeoutMS.yml.template
• override-database-timeoutMS.yml.template
• override-operation-timeoutMS.yml.template

For example, the following would be required to support the difference between creating an index for dropIndex v dropIndexes:

{%- if operation.operation_name == "dropIndex" %}
# Create the index first so dropIndex doesn't return IndexNotFound on
# servers prior to 8.3.
- name: createIndex
  object: *collection
  arguments:
    keys: { x: 1 }
    timeoutMS: 100000
    {% for arg in operation.arguments -%}
    {{arg}}
    {%- endfor %}
{%- endif %}
{%- if operation.operation_name == "dropIndexes" %}
# Create the index first so dropIndex doesn't return IndexNotFound on
# servers prior to 8.3.
- name: createIndex
  object: *collection
  arguments:
    keys: { x: 1 }
    name: "x_1"
{%- endif %}

Additionally, generate-basic-tests.py would have to be refactored to avoid hardcoding keys: {x: 1} while creating an index. We would likely have to create a new tuple / object for "Operations" and at that point we've lost generalization.

[jyemin]

Suggest we remove the following templates since we need to extend the dropIndex operations to include createIndex and generate-basic-tests.py was designed to be single-operation oriented

Can we merge this and deal with the above as follow-on work so that we can unblock drivers whose CI is broken?

[prestonvasquez]

Can we merge this and deal with the above as follow-on work so that we can unblock drivers whose CI is broken?

@jyemin This will cause the Unified Tests / Check if all JSON test files are up-to-date (pull_request) check to fail for all subsequent PRs, which will block merging. Alternatively, we could do one of the following:

1. Temporarily implement the template updates required for this ticket. jinja will likely lead to additional deletions via formatting.
2. Update generate-basic-tests.py to skip the above templates.
3. Temporarily remove this line from github workflow w/ a follow-up ticket:

   specifications/.github/workflows/unified-tests.yml

   Line 59 in a93fa90

   python3 ./source/client-side-operations-timeout/etc/generate-basic-tests.py ./source/client-side-operations-timeout/etc/templates ./source/client-side-operations-timeout/tests

[jyemin]

OK, I see. What do you recommend, assuming we want to merge something by EOD?

[prestonvasquez]

@jyemin I think the second option is best. It's a very small code change and gives us time to re-assess if we've actually outgrown the template pattern for these cases.

[sanych-sun]

LGTM