refactor: solid alerts (@miodec, @fehmer) by fehmer · Pull Request #7567 · monkeytypegame/monkeytype

fehmer · 2026-03-03T12:20:41Z

No description provided.

socket-security · 2026-03-07T10:11:25Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@tanstack/solid-db@0.2.10
	@tanstack/query-db-collection@1.0.27
	@tanstack/pacer-lite@0.2.1

View full report

socket-security · 2026-03-07T10:11:27Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

Copilot

Pull request overview

Refactors the legacy “alerts” dialog into SolidJS popups, introducing a Solid-based inbox (TanStack solid-db) + PSA + notification history UI, and adds a dev-only API for inserting debug inbox items.

Changes:

Replace legacy #alertsPopup DOM/SCSS + imperative JS with SolidJS AlertsPopup + section components.
Add inbox collection/query + debounced flush strategy (TanStack solid-db/query-db-collection) and wire unread count + reward claiming.
Add /dev/addDebugInboxItem contract + backend route/controller + frontend dev UI hook.

Reviewed changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Locks new TanStack DB-related deps and updated vitest peer graph.
packages/contracts/src/dev.ts	Adds `addDebugInboxItem` endpoint to dev contract.
frontend/src/ts/stores/psas.ts	New Solid store for PSA items.
frontend/src/ts/stores/notifications.ts	Adds `useInnerHtml` to notification history entries.
frontend/src/ts/stores/modals.ts	Adds modal IDs for `Alerts` + `DevInboxPicker`.
frontend/src/ts/elements/psa.tsx	Routes PSA additions into the new PSA store.
frontend/src/ts/elements/alerts.ts	Removes legacy alerts popup implementation.
frontend/src/ts/components/popups/alerts/Psas.tsx	New Solid UI for PSA list.
frontend/src/ts/components/popups/alerts/NotificationHistory.tsx	New Solid UI for notification history + copy-details action.
frontend/src/ts/components/popups/alerts/Inbox.tsx	New Solid UI for inbox + claiming/deleting via paced mutations.
frontend/src/ts/components/popups/alerts/AlertsSection.tsx	Shared section wrapper for alerts popup sections.
frontend/src/ts/components/popups/alerts/AlertsPopup.tsx	New Solid alerts popup modal composition + flush-on-close.
frontend/src/ts/components/popups/Popups.tsx	Adds Solid “Popups” mount (currently only Alerts).
frontend/src/ts/components/mount.tsx	Registers `popups` mount target.
frontend/src/ts/components/modals/DevOptionsModal.tsx	Adds dev UI flow to insert debug inbox items.
frontend/src/ts/components/layout/header/Nav.tsx	Opens new `Alerts` modal instead of legacy `showAlerts()`.
frontend/src/ts/components/common/Headers.tsx	Adjusts H2/H3 Tailwind sizing/gap/padding.
frontend/src/ts/components/common/AsyncContent.tsx	Adds `collection/collections` support (for solid-db live queries).
frontend/src/ts/components/common/AnimatedModal.tsx	Extends custom animation params with `marginRight` support.
frontend/src/ts/collections/utils/flushDebounceStrategy.ts	Adds reusable debounced flush strategy wrapper.
frontend/src/ts/collections/inbox.ts	Adds inbox collection + live query + server flush handler.
frontend/src/styles/popups.scss	Removes legacy `#alertsPopup` styling.
frontend/src/styles/media-queries-purple.scss	Removes legacy `#alertsPopup` max-width rule.
frontend/src/index.html	Adds Solid popups mount point.
frontend/src/html/popups.html	Removes legacy alerts dialog markup.
frontend/package.json	Adds TanStack DB-related dependencies.
frontend/tests/components/common/AsyncContent.spec.tsx	Refactors props passing style in tests (no new collection coverage).
backend/src/api/routes/dev.ts	Registers new dev route handler.
backend/src/api/controllers/dev.ts	Implements `addDebugInboxItem` controller.
CLAUDE.md	Updates plan-mode guidance text.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot · 2026-03-07T18:43:11Z

frontend/src/ts/components/common/AsyncContent.tsx

+function fromCollections<T extends Record<string, unknown>>(collections: {
+  [K in keyof T]: Collection<T[K]>;
+}): AsyncMap<T> {
+  return typedKeys(collections).reduce((acc, key) => {
+    const q = collections[key];


AsyncContent now supports collection/collections, but the AsyncContent test suite only covers query/queries. Add tests for collection loading/error/success to prevent regressions.

frontend/src/ts/components/popups/alerts/NotificationHistory.tsx

frontend/src/ts/components/modals/DevOptionsModal.tsx

packages/contracts/src/dev.ts

Copilot · 2026-03-07T18:43:13Z

frontend/src/ts/components/common/AsyncContent.tsx

+    acc[key] = {
+      value: () => q(),
+      isLoading: () => q.isLoading,
+      isError: () => q.isError,


Collection errors won’t surface: fromCollections sets isError but never sets error, so firstError() stays undefined and no error UI/notification is shown. Expose the underlying error (or at least a sentinel) via AsyncEntry.error.

Suggested change

isError: () => q.isError,

isError: () => q.isError,

error: () => (q.isError ? new Error("Collection error") : undefined),

backend/src/api/controllers/dev.ts

frontend/src/ts/components/popups/alerts/Inbox.tsx

frontend/src/ts/collections/inbox.ts

Copilot · 2026-03-07T18:43:14Z

frontend/src/ts/components/popups/alerts/Inbox.tsx

+      const allRewards: AllRewards[] = changes.transaction.mutations.flatMap(
+        (it) => (it.original as InboxItem).rewards,
+      );
+      claimRewards(allRewards);
+    },


Rewards are claimed client-side for every mutation batch. This is only safe if flushPendingChanges throws on any server failure; otherwise XP/badges can be granted locally even though the inbox update failed.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: convert alerts to solidjs component (@fehmer)

0790cea

monkeytypegeorge added backend Server stuff frontend User interface or web stuff labels Mar 3, 2026

fehmer and others added 3 commits March 3, 2026 19:25

wip

32f33f5

wip

737fb57

Merge branch 'master' into feature/solid-inbox

4d1cd52

fehmer changed the title ~~chore: convert alerts to solidjs component (@fehmer)~~ refactor: solid alerts (@fehmer, @miodec) Mar 5, 2026

Miodec and others added 7 commits March 5, 2026 22:27

wip

60460a0

wip

2eb7710

show flex

4f5532d

jsx

fcf62f0

claiming

4bf612d

remove old code

f70df2c

refactor collection

9a14c80

fehmer and others added 2 commits March 7, 2026 11:36

Merge branch 'master' into feature/solid-inbox

a84e2b2

remove sync button, remove test code

3b2727e

monkeytypegeorge removed the backend Server stuff label Mar 7, 2026

fehmer changed the title ~~refactor: solid alerts (@fehmer, @miodec)~~ refactor: solid alerts (@miodec, @fehmer) Mar 7, 2026

Merge branch 'master' into feature/solid-inbox

67b0abd

fehmer marked this pull request as ready for review March 7, 2026 17:29

github-actions bot added the waiting for review Pull requests that require a review before continuing label Mar 7, 2026

Miodec added 2 commits March 7, 2026 18:41

chore: update claude.md

678c905

dev route to add inbox item

e40a22e

monkeytypegeorge added backend Server stuff docs Related to Markdown files and documentation packages Changes in local packages labels Mar 7, 2026

Miodec added 2 commits March 7, 2026 18:57

styling

f01f38a

style

54d7e51

fehmer and others added 6 commits March 7, 2026 19:23

only show delete all if all messages are claimed

d4a5114

move

056d204

recount unread

5dcba27

handle read and unread

81bf142

dont locally insert

2d2d906

use effect to update unread size

57a7f4e

Miodec requested a review from Copilot March 7, 2026 18:33

Copilot started reviewing on behalf of Miodec March 7, 2026 18:33 View session

update claude

4412e8d

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Miodec and others added 8 commits March 7, 2026 19:51

remove ts ignore

40e0e2e

Update frontend/src/ts/components/popups/alerts/NotificationHistory.tsx

47b8a46

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

message

7082f1c

throw if not 200

dfed132

only claim unclaimed awards

9fcb460

fix double claim

75cd6d3

refetch inbox when adding items from dev modal

0406942

collection error handling

da42dab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: solid alerts (@miodec, @fehmer)#7567

refactor: solid alerts (@miodec, @fehmer)#7567
fehmer wants to merge 33 commits intomasterfrom
feature/solid-inbox

fehmer commented Mar 3, 2026

Uh oh!

socket-security bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	isError: () => q.isError,
	isError: () => q.isError,
	error: () => (q.isError ? new Error("Collection error") : undefined),

Uh oh!

Conversation

fehmer commented Mar 3, 2026

Uh oh!

socket-security bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

socket-security bot commented Mar 7, 2026 •

edited

Loading

socket-security bot commented Mar 7, 2026 •

edited

Loading