Fix the incorrect call in SafeRef.#3143
Merged
mattleibow merged 1 commit intomono:mainfrom Feb 4, 2025
Merged
Conversation
mattleibow
approved these changes
Feb 3, 2025
Collaborator
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
Wow! How long was this here for????
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
Also, welcome to SkiaSharp! |
Contributor
Author
Seems to be this since the beginning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
SafeRefshould callsk_refcnt_safe_refinsteadsk_refcnt_safe_unref.Bugs Fixed
Fix the incorrect behavior of
SafeRef.API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist