Skip to content

Enable GL on Windows ARM#3189

Merged
mattleibow merged 2 commits intomainfrom
dev/windows-arm-opengl
Mar 7, 2025
Merged

Enable GL on Windows ARM#3189
mattleibow merged 2 commits intomainfrom
dev/windows-arm-opengl

Conversation

@mattleibow
Copy link
Collaborator

@mattleibow mattleibow commented Mar 6, 2025

Description of Change

This PR just removes the code that prevents OpenGL from working on Windows ARM.

This was initially done in mono/skia@0c75727. The reason for this was there was no OpenGL on ARM. However, recently, there is a way: https://apps.microsoft.com/detail/9nqpsl29bfff

The reason we can just remove this code is because we don't actually link with opengl32 directly and instead load it at runtime.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Copy link
Collaborator Author

The good new s is that this now works! But, the views do not as the yare using OpenTK which uses glfw, and that is not yet built for ARM. I will play with that, but chances are for now we will wait for glfw/glfw#2163

@mattleibow mattleibow mentioned this pull request Mar 7, 2025
3 tasks
@mattleibow mattleibow marked this pull request as ready for review March 7, 2025 16:59
@mattleibow mattleibow merged commit 19c4b3d into main Mar 7, 2025
1 check passed
@mattleibow mattleibow deleted the dev/windows-arm-opengl branch March 7, 2025 17:00
@mattleibow
Copy link
Collaborator Author

Hi folks,

The builds are now available on the preview feed: https://aka.ms/skiasharp-eap/index.json
Let me know if version 3.119.0-preview.0.38 is now working again for you.

As soon as you let me know, I can release this to NuGet and then hopefully a stable version shortly afterwards.

@peternoyes
Copy link

Hi @mattleibow . I think I posted our update elsewhere but just saw this. We have tested the preview build and it works as expected. A stable build with this fix would be much appreciated! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] GRGlInterface.Create() returns null on Windows on Arm

2 participants