Test disposing GRContext does not crash for Metal backend#3258
Merged
mattleibow merged 2 commits intomono:mainfrom Aug 22, 2025
Merged
Test disposing GRContext does not crash for Metal backend#3258mattleibow merged 2 commits intomono:mainfrom
mattleibow merged 2 commits intomono:mainfrom
Conversation
jeremy-visionaid
changed the title
jeremy-visionaid
force-pushed
the
grcontext-metal-finalizer
branch
4 times, most recently
from
a53ebbd to
8a1443c
Compare
jeremy-visionaid
changed the title
jeremy-visionaid
force-pushed
the
grcontext-metal-finalizer
branch
from
8a1443c to
0fb74fb
Compare
5 tasks
mattleibow
requested changes
Aug 19, 2025
Collaborator
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
I am not 100% sure if we are supposed to retain, but according to instruments this does not leak. So I guess we are supposed to?
I see various places that have retain on there, so this is looking safe for now.
1 task
jeremy-visionaid
force-pushed
the
grcontext-metal-finalizer
branch
from
0fb74fb to
c9de72c
Compare
Contributor
Author
|
I've moved the corresponding fix for the double free to mono/skia#159 |
jeremy-visionaid
changed the title
3 tasks
mattleibow
force-pushed
the
grcontext-metal-finalizer
branch
from
50cefd3 to
cc80eb4
Compare
mattleibow
approved these changes
Aug 22, 2025
Collaborator
|
Thanks for all this investigation! |
github-project-automation
bot
moved this from Changes Requested
to Done
in SkiaSharp Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Unit test for double free fixed in
Bugs Fixed
Fixes: #3178
API Changes
None.
Behavioral Changes
None.
Required skia PR
PR Checklist