Build EGL as Win32 and GLESv2 as WASDK to fix unpackaged WinUI loading issues#3338
Merged
mattleibow merged 1 commit intomainfrom Aug 22, 2025
Merged
Build EGL as Win32 and GLESv2 as WASDK to fix unpackaged WinUI loading issues#3338mattleibow merged 1 commit intomainfrom
mattleibow merged 1 commit intomainfrom
Conversation
Contributor
Author
|
/rebase |
This fixes WinUI apps running as unpackaged. Thanks to @TommiGustafsson-HMP Fixes #2968
github-actions
bot
force-pushed
the
dev/fix-2968
branch
from
e38110f to
3b9afde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes WinUI apps running as unpackaged. Thanks for the hard work in figuring all this out @TommiGustafsson-HMP!
I am still investigating the why but it may be because we do
[DllImport]directly with libEGL and thus it has a specific calling convention or some pre-execution code that is failing in unpackaged.I think this fixes the issue as the main WASDK code is in libGLESv2 and not libEGL. And WASDK apps can load and use Win32 binaries just fine since they are all the same thing now - unlike UWP apps.
Bugs Fixed