Enable BufferSecurityCheck for native DLLs to resolve BinSkim BA2007#3404
Merged
mattleibow merged 2 commits intomainfrom Nov 4, 2025
Merged
Enable BufferSecurityCheck for native DLLs to resolve BinSkim BA2007#3404mattleibow merged 2 commits intomainfrom
mattleibow merged 2 commits intomainfrom
Conversation
This change enables the /GS (Buffer Security Check) compiler flag for three native libraries to resolve BinSkim error BA2007: - libHarfBuzzSharp.dll: Added BufferSecurityCheck=true to all configurations in the vcxproj file, including creating the missing Debug|ARM64 ItemDefinitionGroup - libEGL.dll and libGLESv2.dll: Added /GS flag to extra_cflags in the ANGLE GN build configuration The /GS flag enables compile-time buffer overrun detection, which is an important security feature that helps prevent stack-based buffer overflow attacks.
|
Triage Summary Labels will be applied to indicate the affected areas related to security compliance in This issue does not appear to be a regression, as there are no mentions of compatibility issues with previous versions or performance degradation. Detailed Summary and ActionsSummary of the triage:
Summary of the actions that will be performed:
Additional remarks:
This entire triage process was automated by AI and mistakes may have been made. Please let us know so we can continue to improve. |
mattleibow
reviewed
Nov 4, 2025
Contributor
|
@mattleibow I've opened a new pull request, #3405, to work on those changes. Once the pull request is ready, I'll request review from you. |
…cxproj (#3405) * Initial plan * Merge duplicate Debug|Win32 sections in libHarfBuzzSharp.vcxproj Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
mattleibow
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the /GS (Buffer Security Check) compiler flag for three native libraries to resolve BinSkim error BA2007:
The /GS flag enables compile-time buffer overrun detection, which is an important security feature that helps prevent stack-based buffer overflow attacks.
Why
The
/GSflag enables compile-time buffer overrun detection, which is an important security feature that helps prevent stack-based buffer overflow attacks. This resolves the BinSkim BA2007 security compliance error.Testing
After rebuilding the native libraries with these changes, they should pass BinSkim analysis for the BA2007 check.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist