Merged
Conversation
|
Triage Summary Labels will be applied to indicate the affected areas (Build, Compatibility) and the specific operating system (Linux) involved in the issue regarding Docker build scripts and CI configuration. This issue does not appear to be a regression but rather an enhancement regarding compatibility and build processes. Additional remarks:
Detailed Summary and ActionsSummary of the triage:
Summary of the actions that will be performed:
This entire triage process was automated by AI and mistakes may have been made. Please let us know so we can continue to improve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build scripts and related CI configuration to improve cross-platform builds, standardize architecture selection, and enhance support for additional architectures like LoongArch. The main changes involve switching from the deprecated
IMAGE_ARCHmechanism to the modern--platformDocker flag, updating architecture-specific build arguments, and refining package selection for certain platforms.Docker platform and architecture handling:
IMAGE_ARCHvariable and${IMAGE_ARCH}/debianimage references in all relevant Dockerfiles with the--platformflag and standard base images (e.g.,FROM debian:12), aligning with best practices for multi-architecture Docker builds. [1] [2] [3] [4] [5]scripts/Docker/_clang-cross-common.shscript to set the DockerPLATFORMvariable based on the detected machine architecture and to use--platformwhen building images, removing the obsoleteIMAGE_ARCHargument. [1] [2]Architecture-specific build improvements:
--verifyGlibcMax=2.38) for specific architectures likeloongarch64in the Docker build script, ensuring compatibility with CI configuration. [1] [2]CI pipeline updates:
--platform linux/amd64flag in Docker build arguments, ensuring consistent architecture targeting in CI builds. [1] [2]