Merged
Conversation
…structions
- add-api skill: Add Phase 6 native build requirement, clarify that
EntryPointNotFoundException means native library wasn't rebuilt
- bug-fix skill: Add section on when native builds are required vs
when externals-download is sufficient
- copilot-instructions: Add native build commands table, clarify when
to use externals-download vs externals-{platform}, add
EntryPointNotFoundException to failure recognition
- troubleshooting: Add EntryPointNotFoundException as #1 mistake with
clear fix instructions
Key message: If you modify ANY native code (C API), you MUST rebuild
the native library. Tests must PASS - skipping is only for hardware
limitations.
|
Triage Summary Labels will be applied to indicate that the issue pertains to documentation improvements (area/Docs) and specifically affects the SkiaSharp backend (backend/SkiaSharp). This issue is not a regression, as there are no indications of compatibility issues or performance degradation. Additional remarks:
Detailed Summary and ActionsSummary of the triage:
Summary of the actions that will be performed:
This entire triage process was automated by AI and mistakes may have been made. Please let us know so we can continue to improve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the SkiaSharp contribution workflow documentation, focusing on clearer compliance requirements, more robust build and test instructions, and better separation of workflows for adding APIs and fixing bugs. It introduces stricter branch protection guidance, mandates native builds after C API changes, and updates troubleshooting steps to prevent common errors. Additionally, it adds a dedicated skill file for bug fixes and removes the old
implement-issueworkflow, streamlining and clarifying the process for contributors.Branch protection and compliance:
.github/skills/add-api/SKILL.mdand.github/skills/bug-fix/SKILL.md, requiring feature branches for both parent and submodule repositories before making any changes. [1] [2]Build and test workflow improvements:
EntryPointNotFoundExceptionis caused by missing native builds. [1] [2] [3] [4] [5]Bug fix workflow separation:
.github/skills/bug-fix/SKILL.mdfile with a structured workflow for investigating, fixing, and testing bug reports, including patterns for common bug types and mandatory regression testing..github/skills/implement-issue/SKILL.mdand associated bug-fix reference files, consolidating workflows into more focused skills. [1] [2] [3]Checklist and documentation updates: