Skip to content

Bump skia to milestone 120#3576

Open
mattleibow wants to merge 1 commit intomainfrom
dev/update-skia-m120
Open

Bump skia to milestone 120#3576
mattleibow wants to merge 1 commit intomainfrom
dev/update-skia-m120

Conversation

@mattleibow
Copy link
Collaborator

Bump Skia to Milestone 120

Updates the Skia submodule from m119 to m120.

Changes

  • externals/skia: points to dev/update-skia-m120 branch (Update skia to milestone 120 skia#173)
  • SkiaApi.generated.cs: regenerated — adds sk_surface_draw_with_sampling (new upstream function, wrapper deferred)
  • VERSIONS.txt: milestone 120, soname 120.0.0, assembly 3.120.0.0, nuget 3.120.0
  • cgmanifest.json: chrome_milestone 120, updated commit hashes

Breaking changes in Skia m120

Change Impact Fix
GrDirectContext::MakeGL() removed C API compile failure Updated to GrDirectContexts::MakeGL()
GrDirectContext::MakeVulkan() deprecated Compiles but deprecated Proactively updated to GrDirectContexts::MakeVulkan()
SkTypeface::UniqueID() static removed None (not in C API) Removed orphaned impl
SkFont typeface methods → private None (not in C API) No action
GrBackendSemaphore::initGL/glSync removed None (not in C API) No action

Verification

  • ✅ Native build (macOS ARM64): 0 errors
  • ✅ C# build: 0 errors
  • ✅ Tests: 5374 total, 0 failed, 25 hardware skips

Companion PR

Merge sequence

  1. Merge Update skia to milestone 120 skia#173 → squash creates new SHA on skiasharp
  2. Update submodule pointer in this PR to the new SHA
  3. Then merge this PR

- Update externals/skia submodule to dev/update-skia-m120 (m120 merge)
- Regenerate SkiaApi.generated.cs (adds sk_surface_draw_with_sampling)
- Update VERSIONS.txt: milestone 120, soname 120.0.0, assembly 3.120.0.0
- Update cgmanifest.json: chrome_milestone 120, new commit hash
- Update SKILL.md: use Opus model for validation agent

Native build: ✅ (macOS ARM64)
C# build: ✅ (0 errors)
Tests: ✅ (5374 total, 0 failed, 25 hardware skips)

Companion PR: mono/skia#173

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mattleibow mattleibow force-pushed the dev/update-skia-m120 branch from c0a02a1 to c523700 Compare March 25, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant