Skip to content

Remove overlays, are identical for node & browser#2005

Open
cdebost wants to merge 1 commit intomasterfrom
feature/remove-overlays
Open

Remove overlays, are identical for node & browser#2005
cdebost wants to merge 1 commit intomasterfrom
feature/remove-overlays

Conversation

@cdebost
Copy link
Copy Markdown
Collaborator

@cdebost cdebost commented Jan 22, 2019

Related to montagejs/mr#141. Overlay seems to be serving no purpose in this repository.

@hthetiot
Copy link
Copy Markdown
Contributor

hthetiot commented Jan 29, 2019

+1 if master already ready

@hthetiot
Copy link
Copy Markdown
Contributor

Does #1990 use overlay ?

@cdebost
Copy link
Copy Markdown
Collaborator Author

cdebost commented Jan 30, 2019

@hthetiot Different kind of overlay. That PR is for the UI overlay component. In this PR, overlay refers to the extra package.json property that we use to resolve dependencies differently on browser vs node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants