Android text styling#558
Merged
stackotter merged 4 commits intomoreSwift:mainfrom May 8, 2026
Merged
Conversation
stackotter
requested changes
May 7, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Code looks great 🙏 Just figured we should document a couple of the arbitrary-ish decisions we discussed so that we can rediscover the reasoning in future if we ever want to change things
Collaborator
|
In my local testing, I found that these changes break the default font colour of text when using dark mode on Android. The best way to solve that is probably for us to properly detect and respect the system theme. |
stackotter
approved these changes
May 8, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Looks great, thanks! 🙏 Gonna test locally and then merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fonts example, implements text styling in AndroidBackend, and makes Android the first platform to use custom text styles (they actually grow and shrink in response to the system font size setting).