feat(cis): Only whitelist LDAP for CIS profile creation #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Müller <[email protected]>
Flipez
force-pushed
the
rmuller/disable-cis-for-non-ldap
branch
from
a9aed88 to
1f056f4
Compare
bheesham
approved these changes
Sep 25, 2025
Contributor
bheesham
left a comment
bheesham
left a comment
There was a problem hiding this comment.
Ahead of time approval.
We'll still need to work on a way to provision manual profiles (essentially copying this code elsewhere).
Signed-off-by: Robert Müller <[email protected]>
Signed-off-by: Robert Müller <[email protected]>
Signed-off-by: Robert Müller <[email protected]>
Signed-off-by: Robert Müller <[email protected]>
bheesham
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See IAM-1782 for details and corresponding cutover and proposal documents
Updated to allow
forceProfileCreationmetadata to overrule the whitelisted connections to enforce a profile creation when needed (for example, NDAd folks).