-
Notifications
You must be signed in to change notification settings - Fork 152
Issue-1074 Llink to retiring extension example #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rebloor
merged 2 commits into
mozilla:master
from
rebloor:Issue-1074-link-to-retiring-extension-example
Oct 24, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
After writing this comment, I realized this is too big to tackle here. I'm mostly commenting so we can split this out into a separate ticket.
This line caught my eye in part because it swaps apostrophes (U+00027) for right single quotation marks (U+02019). I've seen style guides that mandate one over the other. In my training, I recall being told that HTML content should use an apostrophe rather than a special Unicode character.
I don't want to go into a ton of detail here, but considerations here include the character encoding for the source file, the HTML document, places Unicode or HTML entities can be used, etc.
In order to get a sense of the patterns used in our existing content, I searched the
.mdfiles in this repo for a variety of contractions using both characters. For each contraction, the regular expression used followed the pattern\w<Character><Abbreviation>, where<Character>is either'or’and<Abbreviation>was the abbreviated second word in the contraction. For example,\w'swould matchlet'sand\w’swould matchlet’s.'(U+00027) regexp'(U+00027) occurrences’(U+02019) regexp’(U+02019) occurrences\w's\w’s\w't\w’t\w're\w’re\w've\w’ve\w'll\w’ll\w'd\w’d\w'(s|t|re|ve|ll)\w’(s|t|re|ve|ll)The HTML entities
’and’do not appear source files.