task(content-server): remove intern #18905
Conversation
| test.describe('severity-1', () => { | ||
| // runs all mocha tests - see output here: http://127.0.0.1:3030/tests/index.html | ||
| test('content-server mocha tests', async ({ target, page }, { project }) => { | ||
| test.skip(project.name !== 'local', 'mocha tests are local only'); | ||
| await page.goto(`${target.contentServerUrl}/tests/index.html`, { | ||
| waitUntil: 'load', | ||
| }); | ||
| await page.waitForTimeout(2000); // wait for mocha to load | ||
| await page.evaluate(() => | ||
| (globalThis as any).runner.on( | ||
| 'end', | ||
| () => ((globalThis as any).done = true) | ||
| ) | ||
| ); | ||
| await page.waitForFunction( | ||
| () => (globalThis as any).done, | ||
| {}, | ||
| { timeout: 0 } | ||
| ); | ||
| const failures = await page.evaluate( | ||
| () => (globalThis as any).runner.failures | ||
| ); | ||
| expect(failures).toBe(0); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
If I'm reading right, this was a test to make sure all content-server intern tests completed successfully, and it's safe to remove?
| <h1 className="card-header text-center" id="clear-storage"> | ||
| Browser storage is cleared | ||
| </h1> | ||
| <h1 className="card-header text-center">Browser storage is cleared</h1> |
There was a problem hiding this comment.
ID and comment removed as suggested
| assert.isObject(instance); | ||
| assert.lengthOf(Object.keys(instance), 3); | ||
| assert.equal(instance.method, 'get'); | ||
| assert.equal(instance.path, '/config'); |
There was a problem hiding this comment.
So some of these routes are definately still being used in our frontend. This test calls the /config endpoint which settings uses.
It seems strange to me to remove the test but keep the api route functionality. The team mentioned that these tests are not being run. Would it make sense to migrate them off of intern instead?
To my understanding, when we move completely to a React frontend, some of these backend routes will still be used.
Also, if a test exists but does not run...does it really exists 😅
Because
This pull request
Issue that this pull request solves
Closes: FXA-11695