fix(next): undefined tax location results in error #18967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaberindeZA
commented
Jun 3, 2025
| postalCode: location.postalCode, | ||
| } satisfies TaxAddress; | ||
| if (!location) { | ||
| this.log.log('TaxService.getTaxAddress.noLocation', { ipAddress }) |
Contributor
Author
There was a problem hiding this comment.
Still discussing whether or not to include ipAddress in the console log.
julianpoy
reviewed
Jun 3, 2025
StaberindeZA
force-pushed
the
fxa-11708-handle-empty-ip-address
branch
from
121f3c8 to
831e1d3
Compare
julianpoy
approved these changes
Jun 4, 2025
Because: - NestJSActionService throws an error, listed below when TaxService.getTaxAddress can not resolve the IP address to a location. - Cannot read properties of undefined (reading 'constructor') This commit: - NextJSActionService.getTaxAddress returns empty object when location is undefined. - Logs the IP address to console Closes #FXA-11708
StaberindeZA
force-pushed
the
fxa-11708-handle-empty-ip-address
branch
from
831e1d3 to
3f99181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-11708
Checklist
Put an
xin the boxes that applyAdditional info
I was able to replicate this issue by connecting to the Mozilla VPN - Phoenix AZ node, and navigating to the
/newpage.