Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Jun 5, 2025

Because

  • The localized retry time was incorrect (off by a factor of 1000)

This pull request

  • Fixes the issue by using the exact retryAfter value from the rate-limit lib.

Issue that this pull request solves

Closes: FXA-11819

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Before:
image

After:
image

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner June 5, 2025 00:10
@dschom dschom force-pushed the try-again-later-time-incorrect branch 4 times, most recently from 635bebc to c6ad5b4 Compare June 5, 2025 19:31

request.emitMetricsEvent('customs.blocked');

console.log('!!! localizeTimestamp.format', request.headers['accept-language'], localizeTimestamp.format);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray console.log

@dschom dschom force-pushed the try-again-later-time-incorrect branch from c6ad5b4 to 5cd77d1 Compare June 6, 2025 17:20
@dschom dschom merged commit aff1743 into main Jun 6, 2025
4 of 5 checks passed
@dschom dschom deleted the try-again-later-time-incorrect branch June 6, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants