chore(skip): Add metrics for skip by seen device, security event #19541
+163
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshirley
approved these changes
Oct 3, 2025
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Nice! Code looks good. I think the only thing is the failing tests. Otherwise 
once those are fixed!
| @@ -0,0 +1,5 @@ | |||
| CALL assertPatchLevel('177'); | |||
|
|
|||
| INSERT INTO securityEventNames(name) VALUES ('account.signin_confirm_bypass_known_device'); | |||
Contributor
There was a problem hiding this comment.
welp, I just realized that I messed up the naming where the security event is signin_ and the glean events are login_ 😅 Probably not a big deal
| loginConfirmSkipFor: { | ||
| knownIp: createEventFn('login_confirm_skip_for_known_ip'), | ||
| newAccount: createEventFn('login_confirm_skip_for_new_account'), | ||
| knownDevice: createEventFn('login_confirm_skip_for_known_device'), |
Contributor
There was a problem hiding this comment.
I saw tests failed, I think it's since this new glean event isn't in the packages/fxa-auth-server/test/local/metrics/glean.ts tests.
| }); | ||
|
|
||
| describe('skip for seen user agent', () => { | ||
| describe('skip for known device', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-12477
Checklist
Screenshots (Optional)
security event 50 is skipped via seen device
Other information (Optional)