Skip to content

Conversation

@vpomerleau
Copy link
Contributor

Because

  • Account signup email is used in change 2fa routes instead of primary email

This pull request

  • Pull email from credentials and not original account.email

Issue that this pull request solves

Closes: FXA-12504

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

* Account signup email is used in change 2fa routes instead of primary email

This commit:

* Pull email from credentials and not original account.email

Closes #FXA-12504
@vpomerleau vpomerleau requested a review from a team as a code owner October 8, 2025 12:50
@vpomerleau vpomerleau changed the title fix(auth): Account signup email used in chage 2fa endpoint fix(auth): Account signup email used in change 2fa endpoint Oct 8, 2025

const code = request.payload.code;
const { uid } = request.auth.credentials;
const account = await db.account(uid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saves a db call 👍🏽

@vpomerleau vpomerleau merged commit bb9e3c1 into main Oct 8, 2025
19 checks passed
@vpomerleau vpomerleau deleted the FXA-12504 branch October 8, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants