Update deps for modern Node.js versions#72
Open
SpacingBat3 wants to merge 1 commit intomozilla:masterfrom
Open
Update deps for modern Node.js versions#72SpacingBat3 wants to merge 1 commit intomozilla:masterfrom
SpacingBat3 wants to merge 1 commit intomozilla:masterfrom
Conversation
• Replace `unzip` package with `unzipper`. • Remove `rmdir` package (literally once-liner in Node API can replace, maybe in the past it was useful but now it's literally junk library). • Overall update dependencies to the latest version available (except devDependencies for now).
SpacingBat3
changed the title
Author
|
This should also fix #68. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
This PR updates all dependencies to the latest version, replaces
unzipwithunzipper(unlike to #69 I've also removed theresolutions, I believe those are no longer needed to be specified) and replaces the use ofrmdirwith Node'sfs.rm( /*(...)*/, {recursive:true, force:true}, /*(...)*/). Outside of fixing the build for modern Node.js builds, this also resolves all vulnerability warnings innpm audit).It should also be pointed out that since I've updated some libraries, there might be no support for older Node versions (which I suppose is fine, I believe the oldest version functional should be Node 14 and I find that as a quite old version as well).
Changelog (took from commit description)
unzippackage withunzipper.rmdirpackage (literallyonce-linerone-liner in Node API can replace [it], maybe in the past it was useful but now it's literally junk library).