Closed
Conversation
Owner
|
I did not think about the serialization part. This is indeed much harder than #17949... Many thanks for exploring the idea though! 🙏 |
Collaborator
Author
|
Closing in favor of #22846. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: see #17949 (comment)
Description
I've used the last few days to think about an implementation of
THREE.Sampler. The idea is to have a class aboveTHREE.Texturethat controls the uv transformation.Technically,
THREE.Samplerjust manages the uniformuvTransform. The related properties and methods are moved fromTHREE.TexturetoTHREE.Sampler.Since map properties can now hold
THREE.TextureorTHREE.Sampler, the texture related code is now a bit more complex. Especially the serialization/deserialization logic. It would be cleaner if theTHREE.Sampler->THREE.Texturecomposition would be mandatory. However, I don't think it's possible to make this change with the engine's maturity level.I did not add any legacy warnings nor tested all examples yet. Just want to hear everybody's opinion about the current design. After this iteration, the PR can be refined.
The example webgl_raycast_texture has already been updated to use
THREE.Sampler.