Conversation
Owner
Author
|
Meh... This breaks |
Collaborator
|
Probably these are the cases to consider:
The only official glTF material texture that three.js allows to use uv2 is |
donmccurdy
reviewed
May 1, 2022
|
|
||
| } | ||
|
|
||
| } |
Collaborator
There was a problem hiding this comment.
I think this would do it:
if ( material.aoMap ) {
if ( material.aoMap.userData._gltfTexCoord === 0 && geometry.attributes.uv !== undefined ) {
if ( geometry.attributes.uv2 !== undefined ) {
console.warn( 'THREE.GLTFLoader: Removed unused uv2 attribute.' );
}
geometry.setAttribute( 'uv2', geometry.attributes.uv );
}
}
Contributor
|
Any hope of merging this one since multi-UVs are delayed? Seems like Don's answer is a good one. |
Owner
Author
|
#25721 solved this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a quick workaround until we improve the current uvset code (coming up soon in my todo list!)
Some gltf models may have second uv set but the aoMap may not use it, resulting in broken models.
/cc @elalish @donmccurdy