Optimise GLTFParser.createUniqueName#25969
Merged
donmccurdy merged 2 commits intomrdoob:devfrom May 2, 2023
Merged
Conversation
donmccurdy
approved these changes
May 2, 2023
Collaborator
|
Thanks @benwest! |
CodyJasonBennett
added a commit
to pmndrs/three-stdlib
that referenced
this pull request
May 31, 2023
|
Thanks @benwest, this fix improved my import speed drastically. I had a GLB with about 15000 small meshes. The whole import now takes less than 2 seconds instead of 90 seconds! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I'm loading a big scene with lots of repeated names in it, it's about 3x faster if I get rid of the loop in
GLTFParser.createUniqueName.(I messed this PR up yesterday, hopefully not this time 🙃)