You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the version number in toJSON functions to 4.6, to make it possible to determine old and new files, after changes in Color Management and how colors are serialized.
@repalash This is just a minor suggestion but I would recommend for future PRs that you fork from mrdoob/three.js and not from another fork of three.js (in your case takahirox/three.js). Besides, the PR should also based on latest dev and not on an outdated branch.
Hey yes, I have been trying to do that, but I made this fork several years ago, and GitHub doesn't allow to have multiple forks from the same base repo. One way to do that is to delete the repo and fork again, but I have some branches and npm packages which will get deleted.
Do you have an idea if there's some way to make another fork? or any other suggestion?
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #25989
Description
Update the version number in toJSON functions to 4.6, to make it possible to determine old and new files, after changes in Color Management and how colors are serialized.