Skip to content

Bump metadata.version from toJSON functions to 4.6.#26026

Merged
Mugen87 merged 4 commits intomrdoob:devfrom
repalash:tojson_version_bump
May 9, 2023
Merged

Bump metadata.version from toJSON functions to 4.6.#26026
Mugen87 merged 4 commits intomrdoob:devfrom
repalash:tojson_version_bump

Conversation

@repalash
Copy link
Contributor

@repalash repalash commented May 9, 2023

Fixed: #25989

Description

Update the version number in toJSON functions to 4.6, to make it possible to determine old and new files, after changes in Color Management and how colors are serialized.

@Mugen87
Copy link
Collaborator

Mugen87 commented May 9, 2023

It seems the JOSN files for the unit tests need an update from 4.5 to 4.6 as well.

@github-actions
Copy link

github-actions bot commented May 9, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
637.2 kB (158 kB) 637.2 kB (158 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
427.5 kB (103.7 kB) 427.5 kB (103.7 kB) +0 B

Mugen87 added 3 commits May 9, 2023 16:57
Updated JSON version.
Update JSON version.
Update JSON version.
@Mugen87 Mugen87 added this to the r153 milestone May 9, 2023
@repalash
Copy link
Contributor Author

repalash commented May 9, 2023

Thanks for fixing

@Mugen87 Mugen87 merged commit df58df8 into mrdoob:dev May 9, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented May 9, 2023

@repalash This is just a minor suggestion but I would recommend for future PRs that you fork from mrdoob/three.js and not from another fork of three.js (in your case takahirox/three.js). Besides, the PR should also based on latest dev and not on an outdated branch.

@repalash
Copy link
Contributor Author

repalash commented May 9, 2023

Hey yes, I have been trying to do that, but I made this fork several years ago, and GitHub doesn't allow to have multiple forks from the same base repo. One way to do that is to delete the repo and fork again, but I have some branches and npm packages which will get deleted.
Do you have an idea if there's some way to make another fork? or any other suggestion?
Thanks

@Mugen87
Copy link
Collaborator

Mugen87 commented May 9, 2023

Um, using a different user would be a pragmatic solution. But I can understand if such contributions should be done under your normal account.

@Methuselah96 Methuselah96 mentioned this pull request Jun 4, 2023
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version bump in toJSON after changes in ColorManagement

3 participants