Skip to content

Nodes: Fix UV attributes #26220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 2 commits into from
Jun 8, 2023
Merged

Nodes: Fix UV attributes #26220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be620b7
Nodes: Fix uv attributes
sunag Jun 8, 2023
7fbcb17
cleanup
sunag Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/jsm/nodes/accessors/UVNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class UVNode extends AttributeNode {

const index = this.index;

return 'uv' + ( index > 0 ? index + 1 : '' );
return 'uv' + ( index > 0 ? index : '' );

}

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/renderers/webgl/nodes/WebGLNodeBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ class WebGLNodeBuilder extends NodeBuilder {
for ( const attribute of attributes ) {

// ignore common attributes to prevent redefinitions
if ( attribute.name === 'uv' || attribute.name === 'position' || attribute.name === 'normal' )
if ( /^(position|normal|uv\d?)$/.test( attribute.name ) )
continue;

snippet += `attribute ${attribute.type} ${attribute.name}; `;
Expand Down
1 change: 0 additions & 1 deletion playground/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@
//

renderer.setAnimationLoop( render );
renderer.outputEncoding = THREE.sRGBEncoding;
renderer.toneMapping = THREE.LinearToneMapping;
renderer.toneMappingExposure = 1;
document.body.appendChild( renderer.domElement );
Expand Down