WebXRManager: re-enable getCamera()#26322
Closed
ashconnell wants to merge 1 commit intomrdoob:devfrom
Closed
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
52b7455 to
266ef64
Compare
266ef64 to
7eb99ed
Compare
Contributor
|
🙏 |
Contributor
|
@mrdoob is there an alternative / recommended way to access the array cameras in XR sessions with the getCamera API removed? Otherwise I think that was an oversight... |
Owner
|
Reverted: #26350 🙏 |
|
is renderer.xr.setUserCamera() now removed from release 156 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #26041
Description
WebXRManager.getCamera()was removed in favor ofWebXRManager.setUserCamera()but as others and myself have expressed, this doesn't allow finer control over layers etc.