Support backgrounds (cube, texture, color) via passes#9158
Merged
Conversation
…ePass supports opacity. TexturePass doesn't write to the depth buffer.
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <title>three.js webgl - postprocessing manual msaa</title> |
Collaborator
There was a problem hiding this comment.
webgl - postprocessing backgrounds
Contributor
Author
|
I've further expanded on the features in this PR here: #9163 Adding support for blurring the cube maps, tone mapping, HDR environements (e.g. texture encodings), and support for CubeUV packing. |
|
|
||
| THREE.Pass.call( this ); | ||
|
|
||
| this.scene = scene; |
Owner
There was a problem hiding this comment.
What's this.scene for? I don't think it's being used?
Contributor
Author
There was a problem hiding this comment.
It isn't being used, I was just following the convention of many Passes that take "scene, camera" as their first two parameters and remember they them. I'll remove it.
Owner
There was a problem hiding this comment.
I see, I see. It would be nice to add a comment, otherwise someone will try to clean it up in the future.
Owner
|
Thanks! |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the idea of various easy to use backgrounds (cube, texture, color) via the use of passes. I cleaned up RenderPass, TexturePass. I added CubeTexturePass.
I show how they can be combined in a flexible manner via this example:
/examples/webgl_postprocessing_backgrounds.html