Skip to content

Add Nodeset2 samples#322

Open
mregen wants to merge 31 commits intomainfrom
nodeset2
Open

Add Nodeset2 samples#322
mregen wants to merge 31 commits intomainfrom
nodeset2

Conversation

@mregen
Copy link
Owner

@mregen mregen commented Apr 18, 2024

Proposed changes

Work branch to test latest Modelcompiler

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mregen mregen changed the base branch from master to main February 6, 2025 07:01
@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.27%. Comparing base (4740787) to head (e6b7f3e).

❗ There is a different number of reports uploaded between BASE (4740787) and HEAD (e6b7f3e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4740787) HEAD (e6b7f3e)
24 22
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #322       +/-   ##
===========================================
- Coverage   54.91%   38.27%   -16.65%     
===========================================
  Files         349      251       -98     
  Lines       66506    39785    -26721     
  Branches    13640     8631     -5009     
===========================================
- Hits        36521    15226    -21295     
+ Misses      26001    22759     -3242     
+ Partials     3984     1800     -2184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants