dts: msm8952 & msm8953: add support for Samsung j3poplte and j7poplte by agrecascino · Pull Request #594 · msm8916-mainline/lk2nd

agrecascino · 2025-10-07T21:21:08Z

No description provided.

wonderfulShrineMaidenOfParadise

Minor nitpicks.

wonderfulShrineMaidenOfParadise · 2025-10-08T06:04:50Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3poplte.dts

+			<QCOM_BOARD_ID_MTP 0x06>;
+	soc {


Suggested change

<QCOM_BOARD_ID_MTP 0x06>;

soc {

<QCOM_BOARD_ID_MTP 0x06>;

soc {

wonderfulShrineMaidenOfParadise · 2025-10-08T06:05:17Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3poplte.dts

+			linux,phandle = <0xff>;
+			phandle = <0xff>;
+		};
+	};	


Suggested change

};

};

wonderfulShrineMaidenOfParadise · 2025-10-08T06:10:59Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7poplte.dts

+
+&lk2nd {
+	model = "Samsung J7 Perx (SM-J727P)";
+	compatible = "samsung,j7poplte";


Suggested change

compatible = "samsung,j7poplte";

compatible = "samsung,j7popltespr";

wonderfulShrineMaidenOfParadise · 2025-10-08T06:12:06Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3poplte.dts

+
+&lk2nd {
+	model = "Samsung J3 Emerge (SM-J327P)";
+	compatible = "samsung,j3poplte";


Suggested change

compatible = "samsung,j3poplte";

compatible = "samsung,j3popltespr";

wonderfulShrineMaidenOfParadise · 2025-10-08T06:12:19Z

Documentation/devices.md

 - Redmi Note 3 Pro (kenzo)
 - Redmi Note 5A (ugglite)
 - Redmi Note 5A Prime (ugg)
+- Samsung J3 Emerge (j3poplte)


Suggested change

- Samsung J3 Emerge (j3poplte)

- Samsung J3 Emerge (j3popltespr)

wonderfulShrineMaidenOfParadise · 2025-10-08T06:12:30Z

Documentation/devices.md

 - OPPO R9s/R9sk (R9s/R9sk) (quirky - see comments in `lk2nd/device/dts/msm8953/msm8953-oppo-r9s.dts`)
 - Samsung Galaxy A6+
 - Samsung Galaxy J8 LTE
+- Samsung J7 Perx (j7poplte)


Suggested change

- Samsung J7 Perx (j7poplte)

- Samsung J7 Perx (j7popltespr)

wonderfulShrineMaidenOfParadise · 2025-10-08T06:17:30Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3poplte.dts

+#include <lk2nd.dtsi>
+
+/ {
+	qcom,msm-id = <0x12f 0x00 0x134 0x00 0x135 0x00>;


Is it msm8917 or msm8937?

Varies by carrier. They share the same board, but the sprint variant packages the full MSM8937, all other carriers package the 8917.

wonderfulShrineMaidenOfParadise · 2025-10-08T06:18:11Z

lk2nd/device/dts/msm8953/rules.mk

 	$(LOCAL_DIR)/sdm450-samsung-r04.dtb \
+	$(LOCAL_DIR)/msm8953-samsung-j7poplte.dtb \


Suggested change

$(LOCAL_DIR)/sdm450-samsung-r04.dtb \

$(LOCAL_DIR)/msm8953-samsung-j7poplte.dtb \

$(LOCAL_DIR)/msm8953-samsung-j7popltespr.dtb \

$(LOCAL_DIR)/sdm450-samsung-r04.dtb \

wonderfulShrineMaidenOfParadise · 2025-10-08T06:18:26Z

lk2nd/device/dts/msm8952/rules.mk

 	$(LOCAL_DIR)/msm8917-huawei-agassi.dtb \
+
+QCDTBS += \
+	$(LOCAL_DIR)/msm8917-samsung-j3poplte.dtb \


Suggested change

$(LOCAL_DIR)/msm8917-samsung-j3poplte.dtb \

$(LOCAL_DIR)/msm8917-samsung-j3popltespr.dtb \

barni2000 · 2025-10-28T15:01:46Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3popltespr.dts

+		};
+	};
+
+	reserved-memory {


Are you sure this reserved-memory range is necessary?

barni2000 · 2025-10-28T15:02:50Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3popltespr.dts

+		#size-cells = <0x01>;
+		ranges = <0x00 0x00 0xffffffff>;
+
+		qcom,memshare {


I don't think this memshare node is necessary

The memshare node is necessary, along with the reserved memory regions. Samsung's variant of LK attempts to delete these nodes upon loading the DTB, and if they are not present crashes and reboots the phone.

Would be nice to have a comment with those quirks noted, like in other dts where bootloader wants to update/delete nodes.

barni2000 · 2025-10-28T15:03:30Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7poplte.dts

+	soc {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x0 0x0 0x0 0xffffffff>;


This is part of the skeleton

barni2000 · 2025-10-28T15:03:43Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7popltespr.dts

+		#size-cells = <1>;
+		ranges = <0x0 0x0 0x0 0xffffffff>;
+
+		qcom,memshare {


I don't think it is neccassry

barni2000 · 2025-10-28T15:04:12Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7popltespr.dts

+		};
+	};
+
+	reserved-memory {


I don't think this reserved-memory node is necessary

agrecascino · 2025-11-30T20:43:36Z

I'm going to clean up this PR sometime soon and change the j3poplte port to just cover the j3popltespr variant as I think that resolves the DTB ambiguity. Hopefully that should be enough.

agrecascino · 2025-11-30T22:03:57Z

Force pushed my fixes.

wonderfulShrineMaidenOfParadise · 2025-12-02T10:42:13Z

lk2nd/device/dts/msm8953/rules.mk

 	$(LOCAL_DIR)/msm8953-motorola-potter.dtb \
 	$(LOCAL_DIR)/sdm450-samsung-r04.dtb \
+	$(LOCAL_DIR)/msm8953-samsung-j7popltespr.dtb \


Suggested change

$(LOCAL_DIR)/msm8953-motorola-potter.dtb \

$(LOCAL_DIR)/sdm450-samsung-r04.dtb \

$(LOCAL_DIR)/msm8953-samsung-j7popltespr.dtb \

$(LOCAL_DIR)/msm8953-motorola-potter.dtb \

$(LOCAL_DIR)/msm8953-samsung-j7popltespr.dtb \

$(LOCAL_DIR)/sdm450-samsung-r04.dtb \

TravMurav

Sorry for a delay, see some comments below

TravMurav · 2025-12-14T07:20:30Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3popltespr.dts

+
+/ {
+	qcom,msm-id = <QCOM_ID_MSM8917 0x00>;
+	qcom,board-id = <QCOM_BOARD_ID_MTP 0x00>,


0 clashes with msm8917-mtp. Are you sure you need all those ids?

TravMurav · 2025-12-14T07:21:05Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3popltespr.dts

+		#size-cells = <0x01>;
+		ranges = <0x00 0x00 0xffffffff>;
+
+		qcom,memshare {


Would be nice to have a comment with those quirks noted, like in other dts where bootloader wants to update/delete nodes.

TravMurav · 2025-12-14T07:22:19Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3popltespr.dts

+			linux,phandle = <0xff>;
+			phandle = <0xff>;


I really don't like hardcoded phandles. Please drop those, give this node a label and use it above in memory-region = <0xff>;

TravMurav · 2025-12-14T07:23:01Z

lk2nd/device/dts/msm8952/msm8917-samsung-j3popltespr.dts

+&lk2nd {
+	model = "Samsung J3 Emerge (SM-J327P)";
+	compatible = "samsung,j3popltespr";
+	lk2nd,match-device = "J3POPLTE";


if we're doing match-device and this is mtp-ish, I'd appreciate to see a subnode for j3popwhatever here, like in other dts that cover many devices.

TravMurav · 2025-12-14T07:23:53Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7popltespr.dts

@@ -0,0 +1,72 @@
+// SPDX-License-Identifier: GPL-2.0-only
+


Is the license inherited from somewhere? If this is a new file, I'd appreciate this being BSD-3-Clause

TravMurav · 2025-12-14T07:26:35Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7popltespr.dts

+	/* bootloader refuses the dtb if it cannot delete some nodes. */
+	soc {
+		qcom,memshare {
+			memory-region = <0xff>;


ditto for label/phandle but this is even worse since it points to some random node, who knows if it may crash some bootloader later...

TravMurav · 2025-12-14T07:26:50Z

lk2nd/device/dts/msm8953/msm8953-samsung-j7popltespr.dts

+&lk2nd {
+	model = "Samsung J7 Perx (SM-J727P)";
+	compatible = "samsung,j7popltespr";
+	lk2nd,match-device = "J7POPLTE";


ditto for subnode

wonderfulShrineMaidenOfParadise reviewed Oct 8, 2025

View reviewed changes

barni2000 suggested changes Oct 28, 2025

View reviewed changes

Catherine A. Frederick added 2 commits November 30, 2025 16:49

dts: msm8952: add support for Samsung Galaxy J3 Emerge (j3popltespr)

93b539a

dts: msm8953: add support for Samsung Galaxy J7 Perx (j7popltespr)

6e8c4e3

agrecascino force-pushed the main branch from a58272f to 6e8c4e3 Compare November 30, 2025 21:55

wonderfulShrineMaidenOfParadise reviewed Dec 2, 2025

View reviewed changes

TravMurav reviewed Dec 14, 2025

View reviewed changes

	compatible = "samsung,j7poplte";
	compatible = "samsung,j7popltespr";

	compatible = "samsung,j3poplte";
	compatible = "samsung,j3popltespr";

	- Samsung J3 Emerge (j3poplte)
	- Samsung J3 Emerge (j3popltespr)

		$(LOCAL_DIR)/sdm450-samsung-r04.dtb \
		$(LOCAL_DIR)/msm8953-samsung-j7poplte.dtb \

	$(LOCAL_DIR)/msm8917-samsung-j3poplte.dtb \
	$(LOCAL_DIR)/msm8917-samsung-j3popltespr.dtb \

Conversation

agrecascino commented Oct 7, 2025

Uh oh!

wonderfulShrineMaidenOfParadise left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agrecascino commented Nov 30, 2025

Uh oh!

agrecascino commented Nov 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravMurav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants