fix: add support for windows builds #2651
Open
+56
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build the project on a windows machine there are a few errors relating to file paths and commands used within
tsup.config.tsandpatch-ts.js. I have updated the files to support both linux / mac and windows development but I have not created a new ci job to run on windows (happy to add that if you would like it).tsup failure:

patch failure:

tsup.config.tsis an easy fix as there are simple params that can be added toglob.syncthat solve the path issues.patch-ts.jsis slightly more involved, you cannot run/bin/bashand grep on windows. I have written a simple version using glob to find the file paths, then fs to read the file to search for references of "~/core" etc. This works for both windows and Linux but is significantly slower than using grep so I have kept the grep implementation for non windows builds. Happy to consolidate this if you care more about simplicity over performance (I think the functions are a little bit ugly but hopefully clear).