[select] Reset preserved touch modality after close transition#4367
[select] Reset preserved touch modality after close transition#4367atomiks merged 10 commits intomui:masterfrom
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex ReviewOverviewThis branch fixes the Select touch reopen bug by keeping a hidden keep-mounted popup from recalculating into the wrong side and tiny height while it is fully closed. It also adds a Chromium regression that matches the real long-list repro near the bottom of the viewport. Findings (None)No blocking issues found in this patch. Confidence: 4/5High confidence based on a full-branch pass over the Notes
|
0e01729 to
a2203fb
Compare
Summary
Fixes a Select touch regression where reopening after the close transition can reuse the preserved touch interaction type and reopen from the wrong positioning mode.
This regressed in
4fd87cad4([select] Preserve touch exit animations). That commit landed afterv1.3.0, so this is a post-1.3.0regression. I'm marking this PRinternalandtype: regression; it should not need release notes.Changes
openMethodonce the close transition has fully finished and the popup is no longer mounted.