Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aarongarciah
force-pushed
the
docs-unify-syntax-highlighting
branch
from
df1dfa2 to
b43cb59
Compare
RHP has advanced character highlighting that I don't find in other code highlighting libs. Does PrettyLights have parity? Notice |
@atomiks I noticed. This is still WIP, not ready for review. I need to chat to docs-infra about the missing/broken stuff, but the idea is that there's full feature parity e.g. being able to highlight different words per line. |
aarongarciah
force-pushed
the
docs-unify-syntax-highlighting
branch
from
2d501f4 to
1ce3822
Compare
| In order to open a dialog using a menu, control the dialog state and open it imperatively using the `onClick` handler on the menu item. | ||
|
|
||
| ```tsx {12-13,17-18,24-25,28-29} title="Connecting a dialog to a menu" | ||
| ```tsx title="Connecting a dialog to a menu" |
There was a problem hiding this comment.
Fixing the highlighted lines in this demo, and in Dialog and Menu as well since it's been broken since 5e474fe#diff-eb4681ff3f8398dcc2e093c4106508dcbdbd314339bb1ced876eab0b7e054633L59
| { | ||
| name: basename(path), | ||
| content, | ||
| prettyContent, |
| figure: (props) => <figure className="MdFigure" {...props} />, | ||
| pre: ({ tabIndex, ...props }) => { | ||
| if ('data-precompute' in props) { | ||
| return ( | ||
| <CodeBlock.Root className="MdFigure"> | ||
| <CodeBlockPreComputed {...props} /> | ||
| </CodeBlock.Root> | ||
| ); | ||
| } | ||
|
|
||
| return <figure className="MdFigure" {...props} />; | ||
| return <CodeBlock.Pre {...props} />; |
There was a problem hiding this comment.
I need to double check these changes.
github-actions
bot
added
the
PR: out-of-date
aarongarciah
force-pushed
the
docs-unify-syntax-highlighting
branch
from
0a47d7d to
f6d867f
Compare
github-actions
bot
removed
the
PR: out-of-date
3 participants
WIP - not ready for review
Preview: https://deploy-preview-4429--base-ui.netlify.app/react/handbook/animation
rehype-pretty-codeand custom Rehype plugins in favor of docs-infra Rehype plugins. This means we now only rely on PrettyLights CSS vars for syntax highlighting.shikidependency.TODO
@highlight-textdoesn't work when a line is already highlighted: the whole line getsdata-hl="strong"but the word is not marked e.g. preview, source@highlight-texte.g. preview, source (fixed in [docs-infra] Code Emphasis Fixes mui-public#1247)@highlight-text "handle={demoAlertDialog}"e.g. preview, source@highlight-text 'nativeButton="false"'e.g. preview, source@highlight-text ", 40px"e.g. preview ("SSR fallback" code block), source