Conversation
vladmoroz
requested review from
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aarongarciah
requested review from
aarongarciah
and removed request for
atomiks,
flaviendelangle and
michaldudak
aarongarciah
force-pushed
the
paper-mono
branch
from
ff32a02 to
ffbeae3
Compare
| src: url('/fonts/paper-mono.woff2') format('woff2'); | ||
| font-variation-settings: 'wght' 650; | ||
| /* Reduce the size to balance with the sans-serif fonts */ | ||
| size-adjust: calc(100% * 13.5 / 14); |
There was a problem hiding this comment.
Do you think we still need this? With this, the vertical alignment seems to be a bit off.
| with size-adjust | without size-adjust |
|---|---|
 |
 |
 |
 |
 |
 |
There was a problem hiding this comment.
I'd absolutely keep it personally
When zooming in like this, yeah, its obvious that the letters are different height, but when looking at actual paragraphs I think monospace fonts stand out as way larger and overpowering. Visually it looks more balanced to me when the monospace is downsized.
There was a problem hiding this comment.
It's the vertical alignment inside paragraphs what puts me off. It doesn't happen with the current mono font or Söhne Mono.
4 participants
Back when I was working on the initial docs design, we couldn't find a good monospace font option.
We finally made one at Paper as we've experienced the same problem. This is a pre-release version, but hope it's already an improvement :-)