[TextField] Fix media hover specificity issue#16266
Merged
oliviertassinari merged 3 commits intomui:masterfrom Jun 18, 2019
Merged
[TextField] Fix media hover specificity issue#16266oliviertassinari merged 3 commits intomui:masterfrom
oliviertassinari merged 3 commits intomui:masterfrom
Conversation
-Desc: highlight TextField varient outlines border color on focus event on mobile
Details of bundle changes.Comparing: c0e4103...4965b02
|
-Desc: highlight TextField varient outlines border color on focus event on mobile
oliviertassinari
changed the title
oliviertassinari
added
type: bug
joshwooding
approved these changes
Jun 17, 2019
Collaborator
joshwooding
left a comment
joshwooding
left a comment
There was a problem hiding this comment.
Tested on mobile, works for me
Member
|
The current approach outputs the following CSS: .MuiOutlinedInput-root:hover .MuiOutlinedInput-notchedOutline { /* Specificity = 3 */
border-color: rgba(0, 0, 0, 0.87);
}
.MuiOutlinedInput-root.Mui-focused .MuiOutlinedInput-notchedOutline { /* Specificity = 3 */
border-color: #2196f3;
border-width: 2px;
}
@media (hover: none) {
.MuiOutlinedInput-root:hover .MuiOutlinedInput-notchedOutline:hover .MuiOutlinedInput-notchedOutline { /* Specificity = 5 */
border-color: rgba(0, 0, 0, 0.23);
}
}I have updated the pull request to use the patch proposed in the GitHub issue. It outputs the following CSS: .MuiOutlinedInput-root:hover .MuiOutlinedInput-notchedOutline { /* Specificity = 3 */
border-color: rgba(0, 0, 0, 0.87);
}
@media (hover: none) {
.MuiOutlinedInput-root:hover .MuiOutlinedInput-notchedOutline { /* Specificity = 3 */
border-color: rgba(0, 0, 0, 0.23);
}
}
.MuiOutlinedInput-root.Mui-focused .MuiOutlinedInput-notchedOutline { /* Specificity = 3 */
border-color: #2196f3;
border-width: 2px;
}Notice how the specificity is minimized and the style rule order is correct. |
oliviertassinari
approved these changes
Jun 17, 2019
Member
|
@arminydy It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16149
Highlight TextField varient outlines border color on focus event on mobile